Refactor: extract dynamic fields #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
chrismclarke
changed the title
jfmcquade
approved these changes
Apr 22, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
TODO
Description
Code tidying of function that generates parser lists of dynamic dependencies. This should not change the format of output data, but instead tidies up some of the recursion logic to improve type-safety of return
Review Notes
The changes should only impact sheets when synced. I've updated the flowParser cache version which should force all sheets to re-sync.
Assuming the code logic is working as expected there shouldn't be any changes to synced content
Git Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes